🔫 macos: set TCP_FASTOPEN_FORCE_ENABLE#5
Merged
zonyitoo merged 1 commit intozonyitoo:mainfrom Mar 5, 2023
Merged
Conversation
database64128
added a commit
to database64128/libc
that referenced
this pull request
Mar 3, 2023
This is used to disable the backoff mechanism, otherwise TFO is basically unusable. Definition: https://github.com/apple/darwin-xnu/blob/2ff845c2e033bd0ff64b5b6aa6063a1f8f65aa32/bsd/netinet/tcp.h#L310 Related commits/PRs: zonyitoo/tokio-tfo#5, database64128/tfo-go@c980f6b
database64128
added a commit
to database64128/libc
that referenced
this pull request
Mar 3, 2023
This is used to disable the backoff mechanism, otherwise TFO is basically unusable. Updates rust-lang#1632 and rust-lang#1635 Definition: https://github.com/apple/darwin-xnu/blob/2ff845c2e033bd0ff64b5b6aa6063a1f8f65aa32/bsd/netinet/tcp.h#L310 Related commits/PRs: zonyitoo/tokio-tfo#5, database64128/tfo-go@c980f6b
zonyitoo
reviewed
Mar 3, 2023
zonyitoo
reviewed
Mar 3, 2023
database64128
force-pushed
the
macos-tfo-force-enable
branch
from
d2b7263 to
895e3be
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This disables the absolutely brutal TFO backoff mechanism, so that TFO can actually work.
database64128
force-pushed
the
macos-tfo-force-enable
branch
from
895e3be to
f1c9220
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This disables the absolutely brutal TFO backoff mechanism, so that TFO can actually work.